Repository navigation
Conversation
Preferences stopped a partial list of mail commands, and only while focus was inside it. A Gmail-template "s" still starred the selected thread, and once the Shortcuts page blurred a row, focus sat on the body and "e" archived. Every mail command is now held while Preferences is mounted, wherever focus is; lists inside Preferences still get their own navigation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
Contributor
|
Since #2970 made Preferences its own section, the mail list isn't mounted while Preferences is open anymore, so I'm going to close this one. Thanks for catching it though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing on a Preferences page can act on mail you can't see. The thread list and its toolbar stay mounted behind the Preferences sheet, and their commands are global.
PreferencesRootstopped a hand-picked list of them, with a TODO calling that "a partial/temporary solution", and only while focus was inside Preferences. Measured on master with the Gmail template and a focused thread (copy of a live config, Electron 44.5.1, DevToolsInput.dispatchKeyEvent,queueTaskstubbed):sstarearchiveFocus lands on the body as soon as the Shortcuts page finishes recording a key, because the row blurs itself. So a user setting up shortcuts who keeps typing archives and stars mail behind the page.
MAIL_COMMANDScovers each command the Shortcuts page lists under Actions and Selection, plus the item navigation and paging commands the old list had.core:pop-sheetstays live, so Escape and Gmail'sustill leave Preferences.windowstops these commands when they're fired from outside it (the body). Inside, the existingKeyCommandsRegionstops them on the way out, after any list in Preferences (EditableList'score:next-item) has handled them for itself. Unmounting removes the listeners.Verified:
preferences-root-specmountsPreferencesRootwith a mail-list handler ondocument.bodyfor every command. None reaches it when fired from the body or from inside Preferences, a list inside still getscore:next-item,core:pop-sheetstill passes, and after unmountcore:star-itemreaches the mail list again. Six mutants are red: no window listener, no local stop, stopping inside too, never stopping outside, listeners kept after close, and star dropped from the list. Live, in this branch's build with the same setup as above:s,e,landjfrom inside Preferences and from the body queued nothing, and Preferences stayed open;ustill left it. Lint, prettier and tsc clean; full suite 2444 passing on this branch (master4ebb582fb).Shortcuts page series (one concern each; merge in this order): #2950
[]unbinds, #2951 mail held behind Preferences, #2952 record with +, #2953 remove keys, #2955 conflict warnings, #2956 visual pass, #2957 search, #2958 single-key switch, #2959 Show filter.🤖 Generated with Claude Code