Repository navigation
Conversation
Recording began whenever a row took focus and ended on its own, a single plain key could not be recorded (the row waited for a second one and saved "k then j"), and the result replaced every key the command had. Recording now starts from a + button and says so; a modifier combination ends it at once, a plain key after Mousetrap's one-second sequence timeout; Esc cancels; the key joins the command's existing ones; focus returns to the button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
added 9 commits
October 10, 2026 06:35
…licitly # Conflicts: # app/lang/en.json
…licitly # Conflicts: # app/lang/en.json # app/lang/hu.json # app/lang/pt.json
Contributor
Author
|
@bengotow, a direction question on the Shortcuts page series (#2952–#2959). It's been open five weeks, so rather than keep rebasing it I'd like to know what shape you want it in. As of today all seven are rebased onto master 9a066af and mergeable, and each one passes lint, typecheck and the full suite. Together they change about 1,850 lines outside Options, whichever is easiest for you to review:
Any of these is fine. I'd just rather have a direction than keep it parked. 🤖 Generated with Claude Code |
added 3 commits
November 18, 2026 07:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a shortcut on Preferences > Shortcuts is easy to get wrong. Measured on master (Gmail template, copy of a live config, Electron 44.5.1, DevTools input):
kshowed "K" and saved nothing.kthenjsaved"core:archive-item": "k j", the sequence "K then J".e(issue When a keyboard shortcut is modified, I cannot add alternative shortcut #1529, "I cannot add alternative shortcut").This PR:
preventDefaultkeeps Tab from moving focus too).SEQUENCE_TIMEOUT_MS(1000 ms, Mousetrap's_resetSequenceTimer) for a second one, soealone works andg iis still a sequence.keymap.jsonas a list (withBinding, which skips a key already there). Other commands' entries are kept.user-keymap.ts. The never-firingonKeyPresshandler is gone:preventDefaulton keydown cancels keypress. The page's two instructions now describe +, and their old strings are removed from each language file.Removing keys (an × per key, Clear per section, Clear all) is the follow-up. It needs #2950 for
[]to mean "no keys".Verified:
shortcut-recording-speccovers the helpers (sequence vs modifier syntax,modon each platform, no duplicate key, a missing keymap read silently and a broken one logged). It also mountsCommandItemagainst a temporarykeymap.json: no recorder before +, focus and suspension on +, a single key saved after the timeout alongsideewith other commands kept,g isaved once, Ctrl+K saved at once asmod+k, Esc and blur saving nothing,preventDefaulton recorded keys, and the keyboard resumed on unmount. Every statement and condition added was mutated: 24 of 24 red. Live, in this branch's build (same setup as above, thread focused,queueTaskstubbed): + showed the prompt with focus in the recorder. Pressings, Gmail's star key, queued nothing, and 1.2 s later Archive readE, Swith["e", "s"]saved and focus on +. A second + then Esc saved nothing and left Preferences open. Lint, prettier and tsc clean; full suite 2452 passing on this branch (master4ebb582fb).Shortcuts page series (one concern each; merge in this order): #2950
[]unbinds, #2951 mail held behind Preferences, #2952 record with +, #2953 remove keys, #2955 conflict warnings, #2956 visual pass, #2957 search, #2958 single-key switch, #2959 Show filter.🤖 Generated with Claude Code