Repository navigation
Conversation
KeymapFile created a command's entry only while pushing its first keystroke, so `[]` left no entry and the template's keys stayed bound: there was no way to remove a shortcut, even by editing the file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Recording began whenever a row took focus and ended on its own, a single plain key could not be recorded (the row waited for a second one and saved "k then j"), and the result replaced every key the command had. Recording now starts from a + button and says so; a modifier combination ends it at once, a plain key after Mousetrap's one-second sequence timeout; Esc cancels; the key joins the command's existing ones; focus returns to the button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… or all Each key is a chip with an x that removes it (and any other spelling of the same key), a command the user keymap changed gets a Reset back to the template, each section has a Clear, and Clear All (confirmed) empties every command. A command left with no keys is written as `[]`, which unbinds it. "None" is localized now that it shows on cleared commands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every command bound to a key runs when it is pressed, so adding "s" to Archive while Star has "s" made one key archive and star. The Shortcuts page now marks both keys, says on the row the key was added to which other command it runs, offers to remove it from either, and counts these at the top. The defaults' own shared keys (Outlook's Ctrl+U underlines in the composer and marks unread in the list) are not flagged: KeymapManager keeps each command's keys from before the user keymap so a key the user added can be told from one the template gave. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
added 17 commits
October 10, 2026 06:34
…licitly # Conflicts: # app/lang/en.json
# Conflicts: # app/lang/en.json
# Conflicts: # app/lang/en.json
added 30 commits
October 23, 2026 22:44
…licitly # Conflicts: # app/lang/en.json # app/lang/hu.json # app/lang/pt.json
# Conflicts: # app/lang/en.json # app/lang/hu.json # app/lang/pt.json
# Conflicts: # app/lang/en.json
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #2952 you can add a key that another command already uses, and nothing warns you.
KeymapManagerruns every command bound to a key (ensureKeystrokesRegistereddispatches each in_commandsCache[keys]), so adding Gmail'ssto Archive makessarchive and star. Measured in the #2953 build: recordingson Archive saved["e", "s"]with no notice.Ctrl+Uunderlines in the composer and marks unread in the list (the existingkeymap-manager-specdispatches both),Ctrl+Shift+Lis bulleted list or go to Inbox, andCtrl+Aselects text or threads in every template. Flagging those would warn every user about choices they never made. To tell the two apart,KeymapManagerkeeps each command's keys from before the user keymap (getDefaultBindingsForCommand), andaddedBindingsis a command's keys minus those.modandctrlcount as one key on Windows and Linux.findConflictschecks every command's keys, including commands not listed on the page, such ascore:undo. Commands without a label show their id.Stacked on #2953 (and through it #2952 and #2950).
Verified:
shortcut-conflicts-speccovers the helpers (added keys, mod/ctrl spelling per platform, both sides reported, defaults' overlaps never flagged even on a changed command, each other command named once), a mounted row (both chips marked with the hover text, the message only where the key was added, Remove from / Remove here), and the mounted page (singular and plural counts, counting each added clash once, Remove from Star keeping Star's other keys, silence for Outlook-style overlaps).keymap-manager-speccoversgetDefaultBindingsForCommand. Every statement and condition added was mutated: 25 of 25 red. Live, in this branch's build on a copy of a Gmail-template config (Electron 44.5.1, DevTools input): + on Archive thensshowed the count, flagged S on Archive and Star, and the message. Remove from Star left Star with None and{"core:archive-item": ["e","s"], "core:star-item": []}, and the warnings cleared. Lint, prettier and tsc clean; full suite 2482 passing.Screenshots (copy of a Gmail-template config,
sadded to Archive while Star hass):After Remove from Star:
Shortcuts page series (one concern each; merge in this order): #2950
[]unbinds, #2951 mail held behind Preferences, #2952 record with +, #2953 remove keys, #2955 conflict warnings, #2956 visual pass, #2957 search, #2958 single-key switch, #2959 Show filter.🤖 Generated with Claude Code