Skip to content

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Dec 5, 2025

Description

Removed unnecessary icon imports and their usage from the PipelineDetails and RunDetails components. Specifically:

  • Removed the Network icon and its rendering from PipelineDetails
  • Removed the Videotape icon and its rendering from RunDetails

Do we actually need these? I personally think no icon is cleaner. Also this section has a lot of information already, so adding in this visual flare seems a little too much.

Related Issue and Pull requests

Type of Change

  • Improvement
  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Before

Screenshot 2025-12-05 at 1.48.21 PM.png

After:

Screenshot 2025-12-05 at 1.48.38 PM.png

Test Instructions

Verify that the Pipeline Details and Run Details pages display correctly without the icons that were previously shown next to the pipeline/run names.

Additional Comments

This change simplifies the UI by removing decorative icons that weren't adding significant value to the interface.

Copy link
Collaborator Author

Mbeaulne commented Dec 5, 2025

@Mbeaulne Mbeaulne marked this pull request as ready for review December 5, 2025 16:42
@Mbeaulne Mbeaulne force-pushed the 12-05-adds_copy_to_other_titles branch from 8ab89de to 8fe8f83 Compare December 5, 2025 18:45
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch 2 times, most recently from 267de2b to 4e846a5 Compare December 5, 2025 19:15
@Mbeaulne Mbeaulne force-pushed the 12-05-adds_copy_to_other_titles branch from b890a7c to b9365ea Compare December 5, 2025 19:25
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 4e846a5 to ab73fff Compare December 5, 2025 19:25
@Mbeaulne Mbeaulne mentioned this pull request Dec 5, 2025
8 tasks
@Mbeaulne Mbeaulne force-pushed the 12-05-adds_copy_to_other_titles branch from b9365ea to 5f1ed68 Compare December 5, 2025 20:03
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from ab73fff to 547d092 Compare December 5, 2025 20:03
@Mbeaulne Mbeaulne force-pushed the 12-05-adds_copy_to_other_titles branch from 5f1ed68 to da6b344 Compare December 5, 2025 20:14
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 547d092 to 1198e72 Compare December 5, 2025 20:14
Copy link
Collaborator

camielvs commented Dec 5, 2025

Hmm. My only concern is: if you haven't been paying attention and look back at Tangle, how do you quickly know at a glance if the context panel is showing info on a Pipeline or a Task?

@Mbeaulne Mbeaulne force-pushed the 12-05-adds_copy_to_other_titles branch from da6b344 to 60b3449 Compare December 5, 2025 21:25
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 1198e72 to 7021378 Compare December 5, 2025 21:25
@Mbeaulne Mbeaulne force-pushed the 12-05-adds_copy_to_other_titles branch from 60b3449 to fd8380e Compare December 5, 2025 21:28
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 7021378 to cd93061 Compare December 5, 2025 21:28
Copy link
Collaborator Author

Mbeaulne commented Dec 5, 2025

Pipeline:
Screenshot 2025-12-05 at 4.51.00 PM.png

task:

Screenshot 2025-12-05 at 4.51.11 PM.png

Screenshot 2025-12-05 at 4.51.39 PM.png

I think they look different enough that people will know.

Copy link
Collaborator

camielvs commented Dec 5, 2025

Hmm okay. It's such a minor change. Easy to do something else if needed.

@graphite-app graphite-app bot changed the base branch from 12-05-adds_copy_to_other_titles to graphite-base/1478 December 5, 2025 22:02
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from cd93061 to bb26e9e Compare December 6, 2025 15:14
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1478 to 12-05-adds_copy_to_other_titles December 6, 2025 15:14
@camielvs camielvs changed the base branch from 12-05-adds_copy_to_other_titles to graphite-base/1478 December 6, 2025 15:16
@camielvs camielvs force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from bb26e9e to f3c0e6d Compare December 6, 2025 15:16
@graphite-app graphite-app bot changed the base branch from graphite-base/1478 to master December 6, 2025 15:17
@camielvs camielvs force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from f3c0e6d to 4114954 Compare December 6, 2025 15:17
@Mbeaulne Mbeaulne merged commit 4245255 into master Dec 6, 2025
5 checks passed
Copy link
Collaborator Author

Mbeaulne commented Dec 6, 2025

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants