forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
cleans up pipelineDetails v2 #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2025
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e640e87 to
8e09035
Compare
876fd02 to
97d6e17
Compare
8e09035 to
d5fc138
Compare
97d6e17 to
1a564bc
Compare
d5fc138 to
4b4bf4c
Compare
1a564bc to
0300822
Compare
4b4bf4c to
20cb3bc
Compare
0300822 to
e85e763
Compare
20cb3bc to
921cf8a
Compare
e85e763 to
44eb3d3
Compare
921cf8a to
044bf4c
Compare
44eb3d3 to
9870487
Compare
044bf4c to
2d1c29d
Compare
9870487 to
1536e7f
Compare
2d1c29d to
062519d
Compare
camielvs
approved these changes
Dec 5, 2025
Collaborator
camielvs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally seems good. I will pick up remaining layout and divs and styling etc in #1468
1536e7f to
4e907d8
Compare
062519d to
55c2bc6
Compare
4e907d8 to
58c6a55
Compare
55c2bc6 to
ec2d7b7
Compare
58c6a55 to
4721a38
Compare
ec2d7b7 to
e370733
Compare
1c90540 to
611d344
Compare
e370733 to
11c3d4b
Compare
611d344 to
5c4c89f
Compare
11c3d4b to
7205755
Compare
7205755 to
5fd9355
Compare
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Updated UI components in PipelineDetails and RunDetails to use our UI primitives instead of raw HTML elements. This change implements the new UI guidelines by replacing div/span/h3 elements with
Text,BlockStack, andInlineStackcomponents from our UI library.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Before:

After
Test Instructions
Additional Comments
Added new UI Primitives guidelines to the .cursorrules file to document the preferred approach for future development.