Skip to content

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Dec 5, 2025

Description

Updated UI components in PipelineDetails and RunDetails to use our UI primitives instead of raw HTML elements. This change implements the new UI guidelines by replacing div/span/h3 elements with Text, BlockStack, and InlineStack components from our UI library.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Before:
Screenshot 2025-12-05 at 1.50.46 PM.png

Screenshot 2025-12-05 at 1.50.55 PM.png

After

Screenshot 2025-12-05 at 1.51.15 PM.png

Screenshot 2025-12-05 at 1.51.26 PM.png

Test Instructions

  1. Open the Pipeline Details panel and verify all text, layout, and styling appears correctly
  2. Open the Run Details panel and verify all text, layout, and styling appears correctly
  3. Verify that copy functionality still works properly

Additional Comments

Added new UI Primitives guidelines to the .cursorrules file to document the preferred approach for future development.

Copy link
Collaborator Author

Mbeaulne commented Dec 5, 2025

@Mbeaulne Mbeaulne mentioned this pull request Dec 5, 2025
4 tasks
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from e640e87 to 8e09035 Compare December 5, 2025 17:36
@Mbeaulne Mbeaulne marked this pull request as ready for review December 5, 2025 17:37
@Mbeaulne Mbeaulne mentioned this pull request Dec 5, 2025
4 tasks
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 876fd02 to 97d6e17 Compare December 5, 2025 18:45
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 8e09035 to d5fc138 Compare December 5, 2025 18:45
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 97d6e17 to 1a564bc Compare December 5, 2025 19:15
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from d5fc138 to 4b4bf4c Compare December 5, 2025 19:15
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 1a564bc to 0300822 Compare December 5, 2025 19:25
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 4b4bf4c to 20cb3bc Compare December 5, 2025 19:25
@Mbeaulne Mbeaulne mentioned this pull request Dec 5, 2025
8 tasks
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 0300822 to e85e763 Compare December 5, 2025 20:03
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 20cb3bc to 921cf8a Compare December 5, 2025 20:03
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from e85e763 to 44eb3d3 Compare December 5, 2025 20:14
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 921cf8a to 044bf4c Compare December 5, 2025 20:14
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 44eb3d3 to 9870487 Compare December 5, 2025 21:25
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 044bf4c to 2d1c29d Compare December 5, 2025 21:25
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 9870487 to 1536e7f Compare December 5, 2025 21:28
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 2d1c29d to 062519d Compare December 5, 2025 21:29
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems good. I will pick up remaining layout and divs and styling etc in #1468

@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 1536e7f to 4e907d8 Compare December 5, 2025 22:00
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 062519d to 55c2bc6 Compare December 5, 2025 22:00
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 4e907d8 to 58c6a55 Compare December 6, 2025 15:14
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 55c2bc6 to ec2d7b7 Compare December 6, 2025 15:15
@camielvs camielvs force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 58c6a55 to 4721a38 Compare December 6, 2025 15:17
@camielvs camielvs force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from ec2d7b7 to e370733 Compare December 6, 2025 15:17
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch 2 times, most recently from 1c90540 to 611d344 Compare December 6, 2025 15:20
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from e370733 to 11c3d4b Compare December 6, 2025 15:21
@Mbeaulne Mbeaulne changed the base branch from 12-05-cleans_up_pipelinedetails_v1 to graphite-base/1480 December 6, 2025 15:25
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 11c3d4b to 7205755 Compare December 6, 2025 15:27
@graphite-app graphite-app bot changed the base branch from graphite-base/1480 to master December 6, 2025 15:27
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v2 branch from 7205755 to 5fd9355 Compare December 6, 2025 15:27
@Mbeaulne Mbeaulne merged commit 0c5937a into master Dec 6, 2025
5 checks passed
Copy link
Collaborator Author

Mbeaulne commented Dec 6, 2025

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants