Skip to content

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Dec 5, 2025

Description

Improved the UI layout in pipeline details and run details panels by:

  1. Replacing custom div structures with BlockStack and InlineStack components
  2. Reorganized the pipeline details header for better visual hierarchy
  3. Enhanced the artifacts display in run details with alternating row colors
  4. Updated the RenamePipeline component to use TooltipButton
  5. Improved status display in run details
  6. Added new gap options (5, 6, 8) to BlockStack and InlineStack components

Type of Change

  • Improvement
  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Screenshot 2025-12-05 at 1.49.21 PM.png

Screenshot 2025-12-05 at 1.49.45 PM.png

After:

Screenshot 2025-12-05 at 1.50.04 PM.png

Screenshot 2025-12-05 at 1.50.16 PM.png

Before/after screenshots would be helpful to show the UI improvements

Test Instructions

  1. Open pipeline details panel and verify layout is improved
  2. Check run details panel to ensure artifacts are displayed correctly
  3. Verify rename pipeline tooltip works as expected
  4. Test that all functionality remains intact with the new layout components

Copy link
Collaborator Author

Mbeaulne commented Dec 5, 2025

@Mbeaulne Mbeaulne marked this pull request as ready for review December 5, 2025 17:17
@Mbeaulne Mbeaulne mentioned this pull request Dec 5, 2025
8 tasks
@Mbeaulne Mbeaulne mentioned this pull request Dec 5, 2025
4 tasks
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 3ed3d23 to 267de2b Compare December 5, 2025 18:45
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 876fd02 to 97d6e17 Compare December 5, 2025 18:45
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 267de2b to 4e846a5 Compare December 5, 2025 19:15
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 97d6e17 to 1a564bc Compare December 5, 2025 19:15
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 4e846a5 to ab73fff Compare December 5, 2025 19:25
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 1a564bc to 0300822 Compare December 5, 2025 19:25
@Mbeaulne Mbeaulne mentioned this pull request Dec 5, 2025
8 tasks
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from ab73fff to 547d092 Compare December 5, 2025 20:03
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 0300822 to e85e763 Compare December 5, 2025 20:03
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 547d092 to 1198e72 Compare December 5, 2025 20:14
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from e85e763 to 44eb3d3 Compare December 5, 2025 20:14
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 1198e72 to 7021378 Compare December 5, 2025 21:25
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 44eb3d3 to 9870487 Compare December 5, 2025 21:25
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from 7021378 to cd93061 Compare December 5, 2025 21:28
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 9870487 to 1536e7f Compare December 5, 2025 21:28
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces a horizontal scroll in the context panel for pipeline details

Copy link
Collaborator

camielvs commented Dec 5, 2025

I will fine-tune styling and layout in #1468 so I'm not too fussed about specific visuals

Copy link
Collaborator Author

Mbeaulne commented Dec 5, 2025

This PR introduces a horizontal scroll in the context panel for pipeline details

this is fixed up in the stack

Copy link
Collaborator

camielvs commented Dec 5, 2025

Oh, it is too

@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 1536e7f to 4e907d8 Compare December 5, 2025 22:00
@Mbeaulne Mbeaulne force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch from cd93061 to bb26e9e Compare December 6, 2025 15:14
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 4e907d8 to 58c6a55 Compare December 6, 2025 15:14
@camielvs camielvs force-pushed the 12-05-removes_icons_next_to_title_in_run_and_editor branch 2 times, most recently from f3c0e6d to 4114954 Compare December 6, 2025 15:17
@camielvs camielvs force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 58c6a55 to 4721a38 Compare December 6, 2025 15:17
@Mbeaulne Mbeaulne changed the base branch from 12-05-removes_icons_next_to_title_in_run_and_editor to graphite-base/1479 December 6, 2025 15:20
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 4721a38 to 1c90540 Compare December 6, 2025 15:20
@graphite-app graphite-app bot changed the base branch from graphite-base/1479 to master December 6, 2025 15:20
@Mbeaulne Mbeaulne force-pushed the 12-05-cleans_up_pipelinedetails_v1 branch from 1c90540 to 611d344 Compare December 6, 2025 15:20
@Mbeaulne Mbeaulne merged commit 5c4c89f into master Dec 6, 2025
5 checks passed
Copy link
Collaborator Author

Mbeaulne commented Dec 6, 2025

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants