Skip to content

Tiny bugfixes for things encountered during UTK migration - #5493

Open
joemull wants to merge 6 commits into
r-v1.8.xfrom
b-5489-5490-5491-5492-tiny-bugfixes
Open

Tiny bugfixes for things encountered during UTK migration#5493
joemull wants to merge 6 commits into
r-v1.8.xfrom
b-5489-5490-5491-5492-tiny-bugfixes

Conversation

@joemull

@joemull joemull commented Aug 27, 2026

Copy link
Copy Markdown
Member

Fixes #5489.
Fixes #5490.
Fixes #5491.
Fixes #5492.

@mauromsl mauromsl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looking good

<given-names>{{ author.given_names }}</given-names>
</name>
{% if author.is_correspondence_author %}
{% if author.display_email %}

@mauromsl mauromsl Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there is an overriding setting for hiding displayed emails globally, worth considering using it here?

{% if author.display_email and not journal_settings.article.hide_author_email_links %}

I don't think the importers are consistently providing a mechanism for setting display_email so we might accidentally wipe a large number of email addresses from outgoing feeds that were always intended to be shared

@joemull
joemull requested a review from mauromsl September 3, 2026 10:31
@joemull joemull assigned mauromsl and unassigned joemull Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants