-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix FP for invalid-name on module-level constant with multiple branches
#10677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FP for invalid-name on module-level constant with multiple branches
#10677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! The primer issue feel like it's pre-existing (relaunched three time already, sitll failing), I'm not sure when we introduced it or if the stdlib changed. (https://github.com/pylint-dev/pylint/actions/runs/18615113419/job/53080062484)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10677 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 176 176
Lines 19525 19526 +1
=======================================
+ Hits 18738 18739 +1
Misses 787 787
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
328569f to
0074bf5
Compare
Reopened #9138 for adding a pytest skip. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Pierre Sassoulas <[email protected]>
for more information, see https://pre-commit.ci
|
🤖 Effect of this PR on checked open source code: 🤖 Effect on music21:
Effect on django:
Effect on psycopg:
This comment was generated for commit 3e5f056 |
…l constant with multiple branches (#10684) Fix FP for `invalid-name` on module-level constant with multiple branches (#10677) (cherry picked from commit 6678c90) Co-authored-by: Jacob Walls <[email protected]>
Type of Changes
Description
Closes #10664