Skip to content

SG-44793 Remove .tkdeploy: all exclusions are now global defaults - #1130

Merged
julien-lang merged 2 commits into
masterfrom
ticket/SG-44793-tkdeploy-cleanup
Aug 25, 2026
Merged

SG-44793 Remove .tkdeploy: all exclusions are now global defaults#1130
julien-lang merged 2 commits into
masterfrom
ticket/SG-44793-tkdeploy-cleanup

Conversation

@julien-lang

@julien-lang julien-lang commented Aug 13, 2026

Copy link
Copy Markdown
Member

Problem

tk-core was shipping CI/dev-only files (.coveragerc, .flake8, .pre-commit-config.yaml, azure-pipelines.yml, build_resources.yml, codecov.yml, tests/, docs/) to App Store installs because the .tkdeploy exclusion list was never kept up to date.

Changes

The common CI/dev exclusions have been added as global defaults to the App Store publish tooling. All exclusions that were in this repo's .tkdeploy are now covered by those global defaults, so the file is no longer needed and has been deleted.
The legacy stale entries (.travis.yml, appveyor.yml, .hound.yml) were also removed — they referred to CI tooling no longer used by any Toolkit repo.

Note: these .tkdeploy changes take effect only once the corresponding upstream tooling change is merged.

Related PRs

Testing

Confirmed all previously listed exclusions are covered by the new global defaults.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.09%. Comparing base (0d0f1a3) to head (35313d6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
- Coverage   80.10%   80.09%   -0.02%     
==========================================
  Files         203      203              
  Lines       19537    19537              
==========================================
- Hits        15651    15649       -2     
- Misses       3886     3888       +2     
Flag Coverage Δ
Linux 79.54% <ø> (ø)
Python-3.10 79.91% <ø> (-0.02%) ⬇️
Python-3.11 79.81% <ø> (ø)
Python-3.13 79.81% <ø> (ø)
Python-3.9 79.87% <ø> (ø)
Windows 79.56% <ø> (-0.02%) ⬇️
macOS 79.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the repository-specific .tkdeploy packaging exclusion list, relying instead on new global default exclusions in the App Store publish tooling so CI/dev-only files aren’t shipped in App Store installs.

Changes:

  • Deleted .tkdeploy since its exclusions are intended to be covered by upstream global defaults.
  • Dropped legacy/stale exclusion entries that no longer apply (per PR description).
Suppressed comments (1)

.tkdeploy:1

  • Deleting .tkdeploy changes packaging behavior immediately for any environments still using the pre-upstream version of the App Store publish tooling. Until the upstream change is merged and released everywhere that publishes tk-core, this can reintroduce shipping CI/dev files (tests/docs/etc.) to the App Store.

Consider keeping .tkdeploy (even if minimal) until the upstream defaults are deployed, or add a safeguard in the release/publish pipeline to ensure the new tooling version is in use before publishing this repo.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@stevelittlefish stevelittlefish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these i.e. .travis.yml and appveyor.yml are not in the global exclusions list - I'm assuming they are no longer files that exist and this was intentional.

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@julien-lang

Copy link
Copy Markdown
Member Author

Some of these i.e. .travis.yml and appveyor.yml are not in the global exclusions list - I'm assuming they are no longer files that exist and this was intentional.

@stevelittlefish correct! They are no longer any files in TK repositories matching these names.

@julien-lang
julien-lang merged commit 889c1cd into master Aug 25, 2026
29 checks passed
@julien-lang
julien-lang deleted the ticket/SG-44793-tkdeploy-cleanup branch August 25, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants