SG-44793 Remove .tkdeploy: all exclusions are now global defaults - #1130
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 80.10% 80.09% -0.02%
==========================================
Files 203 203
Lines 19537 19537
==========================================
- Hits 15651 15649 -2
- Misses 3886 3888 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Removes the repository-specific .tkdeploy packaging exclusion list, relying instead on new global default exclusions in the App Store publish tooling so CI/dev-only files aren’t shipped in App Store installs.
Changes:
- Deleted
.tkdeploysince its exclusions are intended to be covered by upstream global defaults. - Dropped legacy/stale exclusion entries that no longer apply (per PR description).
Suppressed comments (1)
.tkdeploy:1
- Deleting
.tkdeploychanges packaging behavior immediately for any environments still using the pre-upstream version of the App Store publish tooling. Until the upstream change is merged and released everywhere that publishestk-core, this can reintroduce shipping CI/dev files (tests/docs/etc.) to the App Store.
Consider keeping .tkdeploy (even if minimal) until the upstream defaults are deployed, or add a safeguard in the release/publish pipeline to ensure the new tooling version is in use before publishing this repo.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
stevelittlefish
left a comment
There was a problem hiding this comment.
Some of these i.e. .travis.yml and appveyor.yml are not in the global exclusions list - I'm assuming they are no longer files that exist and this was intentional.
@stevelittlefish correct! They are no longer any files in TK repositories matching these names. |
Problem
tk-corewas shipping CI/dev-only files (.coveragerc,.flake8,.pre-commit-config.yaml,azure-pipelines.yml,build_resources.yml,codecov.yml,tests/,docs/) to App Store installs because the.tkdeployexclusion list was never kept up to date.Changes
The common CI/dev exclusions have been added as global defaults to the App Store publish tooling. All exclusions that were in this repo's
.tkdeployare now covered by those global defaults, so the file is no longer needed and has been deleted.The legacy stale entries (
.travis.yml,appveyor.yml,.hound.yml) were also removed — they referred to CI tooling no longer used by any Toolkit repo.Note: these
.tkdeploychanges take effect only once the corresponding upstream tooling change is merged.Related PRs
Testing
Confirmed all previously listed exclusions are covered by the new global defaults.