Skip to content

SG-44793 Strip common .tkdeploy exclusions now covered by global defaults - #226

Merged
julien-lang merged 1 commit into
masterfrom
ticket/SG-44793-tkdeploy-cleanup
Aug 25, 2026
Merged

SG-44793 Strip common .tkdeploy exclusions now covered by global defaults#226
julien-lang merged 1 commit into
masterfrom
ticket/SG-44793-tkdeploy-cleanup

Conversation

@julien-lang

@julien-lang julien-lang commented Aug 13, 2026

Copy link
Copy Markdown
Member

Problem

tk-desktop was shipping CI/dev-only files (tests/) to App Store installs. The .tkdeploy exclusion list also referenced .travis.yml, a CI service the project no longer uses.

Changes

tests and the common CI/dev entries are now covered by global defaults added to the App Store publish tooling. The .tkdeploy retains only the repo-specific entry (resources) and removes the now-redundant/stale entries.

Note: these changes take effect only once the corresponding upstream tooling change is merged.

Related PRs

Testing

Confirmed the retained resources entry is repo-specific and not covered by global defaults.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.03%. Comparing base (84e6cb7) to head (34c7ea0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   24.03%   24.03%           
=======================================
  Files          70       70           
  Lines        4061     4061           
=======================================
  Hits          976      976           
  Misses       3085     3085           
Flag Coverage Δ
Linux 23.19% <ø> (ø)
Python-3.10 23.95% <ø> (ø)
Python-3.11 23.95% <ø> (ø)
Python-3.13 23.98% <ø> (+0.09%) ⬆️
Python-3.9 23.97% <ø> (ø)
Windows 23.41% <ø> (ø)
macOS 23.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines the repository-level .tkdeploy packaging exclusions by removing CI/dev-only entries that are intended to be handled by newly introduced global defaults in the App Store publish tooling, leaving only the repo-specific exclusion.

Changes:

  • Removed .travis.yml and tests from .tkdeploy excludes as they are meant to be covered by global defaults.
  • Kept the repo-specific resources exclusion.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .tkdeploy

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as shotgunsoftware/tk-core#1130, why not entirely removing the .tkdeploy file?

@julien-lang

Copy link
Copy Markdown
Member Author

Same as shotgunsoftware/tk-core#1130, why not entirely removing the .tkdeploy file?

@carlos-villavicencio-adsk the resources/ folder is not excluded by default intentionaly due to complex cases like in shotgunsoftware/tk-framework-desktopserver#366.
Therefore, we need to keep the file for now for this case.

@julien-lang
julien-lang merged commit 1e18c9b into master Aug 25, 2026
28 checks passed
@julien-lang
julien-lang deleted the ticket/SG-44793-tkdeploy-cleanup branch August 25, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants