SG-44793 Strip common .tkdeploy exclusions now covered by global defaults - #226
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 24.03% 24.03%
=======================================
Files 70 70
Lines 4061 4061
=======================================
Hits 976 976
Misses 3085 3085
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR streamlines the repository-level .tkdeploy packaging exclusions by removing CI/dev-only entries that are intended to be handled by newly introduced global defaults in the App Store publish tooling, leaving only the repo-specific exclusion.
Changes:
- Removed
.travis.ymlandtestsfrom.tkdeployexcludes as they are meant to be covered by global defaults. - Kept the repo-specific
resourcesexclusion.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
carlos-villavicencio-adsk
left a comment
There was a problem hiding this comment.
Same as shotgunsoftware/tk-core#1130, why not entirely removing the .tkdeploy file?
@carlos-villavicencio-adsk the |
Problem
tk-desktopwas shipping CI/dev-only files (tests/) to App Store installs. The.tkdeployexclusion list also referenced.travis.yml, a CI service the project no longer uses.Changes
testsand the common CI/dev entries are now covered by global defaults added to the App Store publish tooling. The.tkdeployretains only the repo-specific entry (resources) and removes the now-redundant/stale entries.Note: these changes take effect only once the corresponding upstream tooling change is merged.
Related PRs
Testing
Confirmed the retained
resourcesentry is repo-specific and not covered by global defaults.