Skip to content

SG-44793 Strip common .tkdeploy exclusions now covered by global defaults - #366

Merged
julien-lang merged 2 commits into
masterfrom
ticket/SG-44793-tkdeploy-cleanup-no-rebuild
Aug 25, 2026
Merged

SG-44793 Strip common .tkdeploy exclusions now covered by global defaults#366
julien-lang merged 2 commits into
masterfrom
ticket/SG-44793-tkdeploy-cleanup-no-rebuild

Conversation

@julien-lang

@julien-lang julien-lang commented Aug 13, 2026

Copy link
Copy Markdown
Member

Problem

tk-framework-desktopserver was shipping several files that should never reach App Store installs: tests/, .travis.yml, appveyor.yml, and the azure-pipelines/ directory.

Changes

Common CI/dev entries (tests, .travis.yml, appveyor.yml) are now covered by global defaults added to the App Store publish tooling. The .tkdeploy is simplified to only the repo-specific entries: the azure-pipelines/ directory (a folder distinct from azure-pipelines.yml which is handled globally) and the resources/python/ build artefacts.

Note: these changes take effect only once the corresponding upstream tooling change is merged.

Related PRs

Testing

Confirmed all removed entries are covered by the new global defaults. The retained resources/python/* and azure-pipelines entries are specific to this repo.

@julien-lang
julien-lang force-pushed the ticket/SG-44793-tkdeploy-cleanup-no-rebuild branch from 87bd948 to acc02b1 Compare August 13, 2026 11:48
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.82%. Comparing base (5db5ac0) to head (8ce2b11).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   65.82%   65.82%           
=======================================
  Files          24       24           
  Lines        1870     1870           
=======================================
  Hits         1231     1231           
  Misses        639      639           
Flag Coverage Δ
Linux 47.54% <ø> (ø)
Python-3.10 65.82% <ø> (ø)
Python-3.11 65.82% <ø> (ø)
Python-3.13 65.72% <ø> (ø)
Python-3.9 65.79% <ø> (ø)
Windows 63.80% <ø> (ø)
macOS 64.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Simplifies the repository’s .tkdeploy packaging exclusions now that common CI/dev files are handled by global App Store publish defaults, leaving only exclusions that are specific to tk-framework-desktopserver.

Changes:

  • Removed repo-local excludes for common CI/dev artifacts (e.g., tests/, .travis.yml, appveyor.yml) now covered by upstream defaults.
  • Kept/expression-adjusted repo-specific excludes for azure-pipelines/ and resources/python/ build/pipeline artifacts and helper scripts.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as shotgunsoftware/tk-core#1130, why not entirely removing the .tkdeploy file?

@julien-lang

Copy link
Copy Markdown
Member Author

Same as shotgunsoftware/tk-core#1130, why not entirely removing the .tkdeploy file?

Same answer as shotgunsoftware/tk-desktop#226 (comment), the resource folder is not excluded by default. And this is a good thing because, here, in this repository, we need to ship some its content.

@julien-lang
julien-lang merged commit 9b945eb into master Aug 25, 2026
27 checks passed
@julien-lang
julien-lang deleted the ticket/SG-44793-tkdeploy-cleanup-no-rebuild branch August 25, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants