SG-44793 Strip common .tkdeploy exclusions now covered by global defaults - #366
Conversation
87bd948 to
acc02b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 65.82% 65.82%
=======================================
Files 24 24
Lines 1870 1870
=======================================
Hits 1231 1231
Misses 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Simplifies the repository’s .tkdeploy packaging exclusions now that common CI/dev files are handled by global App Store publish defaults, leaving only exclusions that are specific to tk-framework-desktopserver.
Changes:
- Removed repo-local excludes for common CI/dev artifacts (e.g.,
tests/,.travis.yml,appveyor.yml) now covered by upstream defaults. - Kept/expression-adjusted repo-specific excludes for
azure-pipelines/andresources/python/build/pipeline artifacts and helper scripts.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
carlos-villavicencio-adsk
left a comment
There was a problem hiding this comment.
Same as shotgunsoftware/tk-core#1130, why not entirely removing the .tkdeploy file?
Same answer as shotgunsoftware/tk-desktop#226 (comment), the resource folder is not excluded by default. And this is a good thing because, here, in this repository, we need to ship some its content. |
Problem
tk-framework-desktopserverwas shipping several files that should never reach App Store installs:tests/,.travis.yml,appveyor.yml, and theazure-pipelines/directory.Changes
Common CI/dev entries (
tests,.travis.yml,appveyor.yml) are now covered by global defaults added to the App Store publish tooling. The.tkdeployis simplified to only the repo-specific entries: theazure-pipelines/directory (a folder distinct fromazure-pipelines.ymlwhich is handled globally) and theresources/python/build artefacts.Note: these changes take effect only once the corresponding upstream tooling change is merged.
Related PRs
Testing
Confirmed all removed entries are covered by the new global defaults. The retained
resources/python/*andazure-pipelinesentries are specific to this repo.