Refactor HandleConnection #1096
Draft
+597
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
4ee4c6b to
77cb16f
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
3 times, most recently
from
c58662d to
88dd20d
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
2 times, most recently
from
0243d66 to
975e96d
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
2 times, most recently
from
5a9a17f to
2bd09d8
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
975e96d to
c1b04bc
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
2bd09d8 to
7ac151b
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
c1b04bc to
1b2c1df
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
7ac151b to
6dbda92
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
1b2c1df to
17fae45
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
2 times, most recently
from
abb9034 to
4527a03
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
87cb8a1 to
b38e5ec
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
4527a03 to
0d8df5f
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
0d8df5f to
669fa38
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
b38e5ec to
62a4dd8
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
62a4dd8 to
ad5f2be
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
58e539d to
443bb5b
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
9b406a7 to
f964219
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
2 times, most recently
from
cc62eb1 to
c596d45
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
2 times, most recently
from
5789306 to
f337b73
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
2 times, most recently
from
32dac7f to
616fff2
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
f337b73 to
0c80e6d
Compare
3 tasks
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
0c80e6d to
8829abe
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
2 times, most recently
from
2a075fd to
4bb4dca
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
2 times, most recently
from
b13e86e to
e210e0b
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
4bb4dca to
8b691b0
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
e210e0b to
7641e1b
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
8b691b0 to
6cfe339
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
7641e1b to
1fa53c2
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
6cfe339 to
174009d
Compare
This was referenced Oct 28, 2025
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
174009d to
ed65518
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
2 times, most recently
from
adc9360 to
b54b933
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
ed65518 to
c82efe1
Compare
camielvs
force-pushed
the
10-10-refactor_handleconnection
branch
from
c82efe1 to
b2503ef
Compare
camielvs
force-pushed
the
10-08-refactor_addandconnectnode
branch
from
b54b933 to
9eea6fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the
HandleConnectionutility to follow more robust logic and more intuitive code flow. Function is now longer but logic flow is more stable.helps to clean up some of the mess in this function added in #1004
Also adds tests for the file.
No change to app functionality.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/329
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments