Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Sep 30, 2025

Description

Add an env variable for debug_mode, which shows some additional info in the ui.

Currently used to display ReactFlow node ids and show handle info when hovered.

Related Issue and Pull requests

Progresses Shopify/oasis-frontend#261

Type of Change

  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

Debug Mode Disabled:

  • Should not see node ids on cards
  • Should not see node info tooltips when hovering handles

Debug mode Enabled:

  • opposite of the above

Debug Mode Not Defined

  • Should default to disabled state

Additional Comments

Copy link
Collaborator Author

camielvs commented Sep 30, 2025

@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from ea1273a to f97f59a Compare October 1, 2025 23:16
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch 3 times, most recently from ac15e08 to 281533c Compare October 7, 2025 23:23
@camielvs camielvs force-pushed the 09-29-migrate_legacy_nodeid_utilities_to_nodemanager branch from 3321611 to 2f84d5f Compare October 7, 2025 23:23
This was referenced Oct 7, 2025
@camielvs camielvs changed the base branch from 09-29-migrate_legacy_nodeid_utilities_to_nodemanager to graphite-base/1016 October 7, 2025 23:48
@camielvs camielvs changed the base branch from graphite-base/1016 to 09-29-implement_node_manager October 7, 2025 23:48
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 2f84d5f to 10473ce Compare October 8, 2025 00:38
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 281533c to 27ccde3 Compare October 8, 2025 00:38
@camielvs camielvs changed the base branch from 09-29-implement_node_manager to graphite-base/1016 October 8, 2025 00:55
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 27ccde3 to 092d37c Compare October 8, 2025 00:55
@camielvs camielvs force-pushed the graphite-base/1016 branch from 10473ce to aef47ff Compare October 8, 2025 00:55
@camielvs camielvs changed the base branch from graphite-base/1016 to 10-07-usenodemanager_hook October 8, 2025 00:55
@camielvs camielvs changed the base branch from 10-07-usenodemanager_hook to graphite-base/1016 October 8, 2025 01:06
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 092d37c to 7888535 Compare October 8, 2025 01:06
@camielvs camielvs changed the base branch from graphite-base/1016 to 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids October 8, 2025 01:06
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 7888535 to eeabed0 Compare October 8, 2025 01:09
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from 9c8c8f8 to 3076c14 Compare October 8, 2025 01:09
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from e83ef69 to c754609 Compare October 17, 2025 18:47
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch 2 times, most recently from 45adef9 to c099a92 Compare October 17, 2025 21:42
@camielvs camielvs requested a review from Mbeaulne October 17, 2025 21:43
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch 3 times, most recently from 8be46ba to 609e209 Compare October 23, 2025 16:35
@camielvs camielvs force-pushed the 10-08-add_input_id_and_output_id_conversions branch from 3c13bdc to 5559d1d Compare October 23, 2025 16:35
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 609e209 to a8907f7 Compare October 23, 2025 19:34
@camielvs camielvs force-pushed the 10-08-add_input_id_and_output_id_conversions branch from 5559d1d to 0d31b48 Compare October 23, 2025 19:34
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from a8907f7 to 9b83881 Compare October 23, 2025 23:23
@camielvs camielvs force-pushed the 10-08-add_input_id_and_output_id_conversions branch 2 times, most recently from 6298203 to bd771a1 Compare October 24, 2025 00:15
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 9b83881 to 2e8661a Compare October 24, 2025 00:15
Copy link
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not include "debug" mode into the final version - we can move this PR on top of the stack

@camielvs camielvs changed the base branch from 10-08-add_input_id_and_output_id_conversions to graphite-base/1016 October 28, 2025 21:04
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 2e8661a to f5e5941 Compare October 28, 2025 21:04
@camielvs camielvs changed the base branch from graphite-base/1016 to 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs October 28, 2025 21:05
Copy link
Collaborator Author

I have restacked this PR to the top of the stack so it can still be used for review purposes. When the stack is approved I will close this PR.

@maxy-shpfy maxy-shpfy marked this pull request as draft October 30, 2025 16:56
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from f5e5941 to d78b343 Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from 64a0be1 to a25a48a Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from d78b343 to f5fa34d Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from 190fa20 to 2700fb6 Compare October 31, 2025 00:23
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from f5fa34d to 1cc93da Compare October 31, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants