Skip to content

Refactor addAndConnectNode #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
camielvs wants to merge 1 commit into
base: 10-08-fix_node_replacement_issues_on_io_rename
Choose a base branch
from
Draft

Refactor addAndConnectNode #1089

camielvs wants to merge 1 commit into from
+439 −131

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Oct 9, 2025 •
edited
Loading

Description

Refactor addAndConnectNode to make it more human readable and logical by more smartly utilizing the node manager system to simplify logic statements and conditionals.

Also adds tests for the file.

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/328

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

This functionality relates to the ghostNode interactions.

  1. have "Published Component Library" beta disabled (ghost nodes not supported yet in new component library)
  2. click and drag from a task output to see a hit node telling you to press tab
  3. tab through the various eligible tasks that can be placed alongside the drag operation - you should see the previews
  4. drop the task & connection onto the canvas
  5. it should transform from a ghost node to a real task node and automatically connect as it usually would

Additional Comments

This was referenced Oct 9, 2025
Draft
Closed
Closed
@camielvs Graphite App
Copy link
Collaborator Author

camielvs commented Oct 9, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 10-08-move_io_node_handles_into_node_manager branch from 9baa419 to 48d97de Compare October 9, 2025 01:27
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch 2 times, most recently from 193cf57 to fd7edd0 Compare October 9, 2025 01:44
@camielvs camielvs force-pushed the 10-08-move_io_node_handles_into_node_manager branch from 48d97de to 16889de Compare October 9, 2025 01:44
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch 2 times, most recently from 859d5bc to 1d7d9e4 Compare October 9, 2025 16:52
@camielvs camielvs force-pushed the 10-08-move_io_node_handles_into_node_manager branch from 16889de to 14a9005 Compare October 9, 2025 16:52
@camielvs camielvs changed the base branch from 10-08-move_io_node_handles_into_node_manager to graphite-base/1089 October 9, 2025 18:49
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 1d7d9e4 to b871988 Compare October 9, 2025 18:49
@camielvs camielvs force-pushed the graphite-base/1089 branch from 14a9005 to 2fa3659 Compare October 9, 2025 18:49
@camielvs camielvs changed the base branch from graphite-base/1089 to 10-08-fix_node_replacement_issues_on_io_rename October 9, 2025 18:50
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 2fa3659 to f7f0199 Compare October 9, 2025 19:19
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from b871988 to ec381ea Compare October 9, 2025 19:19
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from f7f0199 to 640fd57 Compare October 10, 2025 18:08
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from ec381ea to 4ee4c6b Compare October 10, 2025 18:08
@camielvs camielvs mentioned this pull request Oct 10, 2025
Draft
3 tasks
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 4ee4c6b to 77cb16f Compare October 10, 2025 19:44
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 640fd57 to 45ef183 Compare October 10, 2025 19:56
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 77cb16f to 1e7d67e Compare October 10, 2025 19:56
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 45ef183 to 4a86a01 Compare October 10, 2025 20:44
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 1e7d67e to 0243d66 Compare October 10, 2025 20:44
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 4a86a01 to 83e04a1 Compare October 10, 2025 20:47
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch 2 times, most recently from 975e96d to c1b04bc Compare October 11, 2025 00:32
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from 069c913 to fc45d63 Compare October 14, 2025 19:56
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from 2d86930 to b6c0b7d Compare October 17, 2025 21:41
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 9315807 to 9b406a7 Compare October 17, 2025 21:41
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from b6c0b7d to f4b579c Compare October 17, 2025 21:42
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch 2 times, most recently from f964219 to 5789306 Compare October 22, 2025 20:18
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from f4b579c to 4190130 Compare October 22, 2025 20:18
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 5789306 to f337b73 Compare October 22, 2025 22:19
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 292963c to 76acaa5 Compare October 23, 2025 16:35
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from f337b73 to 0c80e6d Compare October 23, 2025 16:35
@camielvs camielvs mentioned this pull request Oct 23, 2025
Draft
3 tasks
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 0c80e6d to 8829abe Compare October 23, 2025 20:05
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from 349bbc8 to 28a303a Compare October 23, 2025 20:11
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch 2 times, most recently from b13e86e to e210e0b Compare October 23, 2025 23:23
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 3abfd3a to cddf9de Compare October 24, 2025 00:15
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from e210e0b to 7641e1b Compare October 24, 2025 00:15
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from cddf9de to 4ba5633 Compare October 28, 2025 21:04
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 7641e1b to 1fa53c2 Compare October 28, 2025 21:04
This was referenced Oct 28, 2025
Draft
Closed
@maxy-shpfy maxy-shpfy marked this pull request as draft October 30, 2025 16:55
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from 1fa53c2 to adc9360 Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 4ba5633 to 0bd4ecc Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from adc9360 to b54b933 Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 0bd4ecc to 4601f48 Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 4601f48 to 7a8cb63 Compare October 31, 2025 00:23
@camielvs camielvs force-pushed the 10-08-refactor_addandconnectnode branch from b54b933 to 9eea6fc Compare October 31, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxy-shpfy maxy-shpfy Awaiting requested review from maxy-shpfy

@Mbeaulne Mbeaulne Awaiting requested review from Mbeaulne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camielvs @Mbeaulne @maxy-shpfy