Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Oct 23, 2025

Description

Output nodes copied between instances of the app will now have their graphOutputValues also copied. This means that when pasted they will automatically reconnect to the relevant tasks.

This was made possible by modifying the copy + paste schema to also include outputValues for output nodes that were copied.

Note this change in schema means it's not possible to copy + paste between staging/production and local dev until this PR has been fully deployed.

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/314

Type of Change

  • Bug fix

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Open two different editor instances of Oasis
  2. In one of them make a simple pipeline that involves, somewhere, a task connected to an output node
  3. copy the pipeline you have made by selecting all the nodes (cmd+A) and copy to clipboard (cmd+C)
  4. paste (cmd+v) the pipeline into the second editor instance
  5. All nodes should paste correctly and be connected and linked as expected, including output nodes
    (previously output nodes would be pasted and disconnected)

note: this will not work between code environments (local/staging/prod) until this PR has been deployed to all of them.

Additional Comments

Copy link
Collaborator Author

camielvs commented Oct 23, 2025

@camielvs camielvs mentioned this pull request Oct 23, 2025
3 tasks
@camielvs camielvs marked this pull request as ready for review October 23, 2025 17:51
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch 2 times, most recently from c226426 to a10a105 Compare October 23, 2025 20:05
@camielvs camielvs force-pushed the 10-14-fix_io_node_copy_paste branch from b72a03b to 61f09a9 Compare October 23, 2025 20:05
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from a10a105 to ff79ad4 Compare October 23, 2025 20:11
@camielvs camielvs force-pushed the 10-14-fix_io_node_copy_paste branch from 61f09a9 to 410d058 Compare October 23, 2025 20:11
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from ff79ad4 to 7d6825e Compare October 23, 2025 23:23
@camielvs camielvs force-pushed the 10-14-fix_io_node_copy_paste branch from 18d7353 to 2c65cbf Compare October 24, 2025 00:15
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from 7d6825e to 591101a Compare October 24, 2025 00:15
@camielvs camielvs force-pushed the 10-14-fix_io_node_copy_paste branch from 2c65cbf to 70314be Compare October 28, 2025 21:04
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from 591101a to 64a0be1 Compare October 28, 2025 21:04
@maxy-shpfy maxy-shpfy marked this pull request as draft October 30, 2025 16:56
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from 64a0be1 to a25a48a Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 10-14-fix_io_node_copy_paste branch 2 times, most recently from 80ac27b to 28dbb2b Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from a25a48a to 190fa20 Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-14-fix_io_node_copy_paste branch from 28dbb2b to ff591fa Compare October 31, 2025 00:23
@camielvs camielvs force-pushed the 10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs branch from 190fa20 to 2700fb6 Compare October 31, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants