forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
Fix Disconnected Output Nodes when Copy + Paste between Tabs #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
camielvs
wants to merge
1
commit into
10-14-fix_io_node_copy_paste
Choose a base branch
from
10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs
base: 10-14-fix_io_node_copy_paste
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix Disconnected Output Nodes when Copy + Paste between Tabs #1186
camielvs
wants to merge
1
commit into
10-14-fix_io_node_copy_paste
from
10-23-fix_disconnected_output_nodes_when_copy_paste_between_tabs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c226426 to
a10a105
Compare
b72a03b to
61f09a9
Compare
a10a105 to
ff79ad4
Compare
61f09a9 to
410d058
Compare
ff79ad4 to
7d6825e
Compare
18d7353 to
2c65cbf
Compare
7d6825e to
591101a
Compare
2c65cbf to
70314be
Compare
591101a to
64a0be1
Compare
This was referenced Oct 28, 2025
64a0be1 to
a25a48a
Compare
80ac27b to
28dbb2b
Compare
a25a48a to
190fa20
Compare
28dbb2b to
ff591fa
Compare
190fa20 to
2700fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Output nodes copied between instances of the app will now have their graphOutputValues also copied. This means that when pasted they will automatically reconnect to the relevant tasks.
This was made possible by modifying the copy + paste schema to also include outputValues for output nodes that were copied.
Note this change in schema means it's not possible to copy + paste between staging/production and local dev until this PR has been fully deployed.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/314
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
(previously output nodes would be pasted and disconnected)
note: this will not work between code environments (local/staging/prod) until this PR has been deployed to all of them.
Additional Comments