Fix inability to delete edges #1040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2025
Draft
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
from
0c23698 to
392db72
Compare
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
from
d907fc5 to
8c6b0e0
Compare
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
2 times, most recently
from
c8f2440 to
96e29ab
Compare
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
2 times, most recently
from
c073c29 to
2c0c04d
Compare
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
from
96e29ab to
794e360
Compare
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
from
2c0c04d to
0cce84d
Compare
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
from
794e360 to
1b5752a
Compare
camielvs
force-pushed
the
10-01-rework_taskinput_and_taskoutput_logic
branch
from
0cce84d to
6c541af
Compare
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
from
1b5752a to
2cfd3d0
Compare
camielvs
changed the base branch from
10-01-rework_taskinput_and_taskoutput_logic
to
graphite-base/1040
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
from
2cfd3d0 to
fe46b33
Compare
camielvs
force-pushed
the
graphite-base/1040
branch
from
6c541af to
a0239ca
Compare
camielvs
changed the base branch from
graphite-base/1040
to
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
camielvs
changed the base branch from
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
to
graphite-base/1040
camielvs
force-pushed
the
graphite-base/1040
branch
from
a0239ca to
7888535
Compare
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
from
fe46b33 to
46cbfa8
Compare
camielvs
changed the base branch from
graphite-base/1040
to
09-29-add_debug_mode_for_viewing_reactflow_node_ids
camielvs
force-pushed
the
09-29-add_debug_mode_for_viewing_reactflow_node_ids
branch
from
7888535 to
eeabed0
Compare
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
from
46cbfa8 to
dfd9105
Compare
camielvs
force-pushed
the
10-01-fix_inability_to_delete_edges
branch
from
dfd9105 to
dda82e4
Compare
camielvs
force-pushed
the
09-29-add_debug_mode_for_viewing_reactflow_node_ids
branch
from
eeabed0 to
6022793
Compare
camielvs
changed the base branch from
09-29-add_debug_mode_for_viewing_reactflow_node_ids
to
graphite-base/1040
This was referenced Oct 8, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Folded into #1017
Fixes an issue introduced in the recent switch to a more granular node classification system that prevented edges/connections from being deleted. The
removeEdgemethod has now be updated to be aware of the new handle id system.As part of this the
removeEdgemethod has been refactored a little to be more readable. it now also supports deleting directinput->outputconnections (even though these are not possible in the UI), just in case a user somehow introduces them via direct yaml editingRelated Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments