Cleanup TaskDetails #1464

camielvs · 2025-12-02T22:11:23Z

Description

Move TaskDetails onto UI primitives & ContextPanel Blocks

Related Issue and Pull requests

Type of Change

Cleanup/Refactor

Checklist

I have tested this does not break current pipelines / runs functionality
I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

No change to app functionality. UI update only. Confirm that the interface works and shows info as expected.

Additional Comments

camielvs · 2025-12-02T22:11:42Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Break TaskActions into two sections #1550
Rework Pipeline Action Buttons into Action Framework #1544
Rework Task Action Buttons into Action Framework #1534
Rework Run Action Buttons into Action Framework #1524
Rework CodeViewer Implementation #1527
Cleanup RunDetails #1508
Cleanup PipelineDetails #1468
Cleanup TaskDetails #1464 👈 (View in Graphite)
Cleanup ExecutionDetails #1471
Add UI Blocks to Context Panel #1470
Update Link Component #1472
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

src/components/shared/ExecutionDetails/ExecutionDetails.tsx

src/components/shared/TaskDetails/Blocks/ActionBlock.tsx

src/components/shared/ContextPanel/Blocks/ActionBlock.tsx

maxy-shpfy · 2025-12-04T00:41:33Z

src/components/shared/ExecutionDetails/ExecutionDetails.tsx

-  if (!hasExecutionData) {
-    return null;
-  }
+  } = useFetchContainerExecutionState(executionId, backendUrl);


NIT: by using useSuspenseQuery and withSuspenseWrapper you can clean up skeleton and error logic.

useFetchContainerExecutionState seems to be used only in this component, so refactoring is straight forward.

maxy-shpfy · 2025-12-04T00:43:57Z

src/components/shared/ContextPanel/Blocks/ActionBlock.tsx

+  };
+
+  const handleCopyYaml = () => {
+    copyToYaml(


NIT: copyToYamlis used ONLY in this place. I would co-locate it next to the usage.

src/components/shared/TaskDetails/Blocks/shared.ts

maxy-shpfy · 2025-12-04T00:47:03Z

src/components/shared/ContextPanel/Blocks/ActionBlock.tsx

+  const pythonOriginalCode =
+    componentSpec?.metadata?.annotations?.original_python_code;
+
+  const stringToPythonCodeDownload = () => {


Can be stable helper function outside of the Component.

src/components/shared/TaskDetails/Blocks/LinkBlock.tsx

maxy-shpfy · 2025-12-04T00:50:31Z

src/components/shared/ContextPanel/Blocks/TextBlock.tsx

+  const { isCopied, isTooltipOpen, handleCopy, handleTooltipOpen } =
+    useCopyToClipboard(text);
+
+  const copyButton = useMemo(


Dont know why it should memoized compared to just being a JSX markup. NIT: if we want to keep content DRY - maybe it can be just a separate local component?

maxy-shpfy

See some regression in Component Details Dialog.

Screen Recording 2025-12-03 at 4.52.59 PM.mov (uploaded via Graphite)

src/components/shared/TaskDetails/Actions.tsx

camielvs · 2025-12-11T01:05:00Z

src/components/shared/ReactFlow/FlowCanvas/TaskNode/TaskOverview/TaskOverview.tsx

              url={taskSpec.componentRef.url}
              onDelete={callbacks.onDelete}
              status={status}
-              hasDeletionConfirmation={false}


camielvs force-pushed the 12-02-cleanup_taskdetails branch from cf86a9d to 6c22aea Compare December 2, 2025 23:54

camielvs marked this pull request as ready for review December 2, 2025 23:56

camielvs requested review from Mbeaulne and maxy-shpfy December 2, 2025 23:56

Mbeaulne reviewed Dec 3, 2025

View reviewed changes

camielvs force-pushed the 12-02-cleanup_taskdetails branch from 6c22aea to f1fefa5 Compare December 3, 2025 20:35

camielvs requested a review from Mbeaulne December 3, 2025 20:47

maxy-shpfy reviewed Dec 4, 2025

View reviewed changes

src/components/shared/TaskDetails/Blocks/shared.ts Outdated Show resolved Hide resolved

maxy-shpfy reviewed Dec 4, 2025

View reviewed changes

src/components/shared/TaskDetails/Blocks/LinkBlock.tsx Outdated Show resolved Hide resolved

maxy-shpfy reviewed Dec 4, 2025

View reviewed changes

maxy-shpfy requested changes Dec 4, 2025

View reviewed changes

camielvs mentioned this pull request Dec 4, 2025

Cleanup PipelineDetails #1468

Draft

3 tasks

camielvs force-pushed the 12-02-cleanup_taskdetails branch from f1fefa5 to 17c6996 Compare December 4, 2025 21:26

camielvs marked this pull request as draft December 4, 2025 21:44

camielvs changed the base branch from master to graphite-base/1464 December 4, 2025 21:52

camielvs force-pushed the 12-02-cleanup_taskdetails branch from 17c6996 to 748d25b Compare December 4, 2025 21:52

camielvs changed the base branch from graphite-base/1464 to 12-04-add_ui_blocks_to_context_panel December 4, 2025 21:53

camielvs mentioned this pull request Dec 4, 2025

Add UI Blocks to Context Panel #1470

Draft

4 tasks

camielvs changed the base branch from 12-04-add_ui_blocks_to_context_panel to graphite-base/1464 December 4, 2025 21:59

camielvs force-pushed the 12-02-cleanup_taskdetails branch from 748d25b to 4f787bc Compare December 4, 2025 21:59

camielvs force-pushed the graphite-base/1464 branch from e08a5ab to 49d4edd Compare December 4, 2025 21:59

camielvs changed the base branch from graphite-base/1464 to 12-04-cleanup_executiondetails December 4, 2025 21:59

camielvs mentioned this pull request Dec 4, 2025

Cleanup ExecutionDetails #1471

Draft

3 tasks

camielvs force-pushed the 12-02-cleanup_taskdetails branch from 4f787bc to ef11837 Compare December 4, 2025 22:29

camielvs force-pushed the 12-04-cleanup_executiondetails branch from 49d4edd to 533c465 Compare December 4, 2025 22:44

camielvs force-pushed the 12-02-cleanup_taskdetails branch from ef11837 to 04c9d4b Compare December 4, 2025 22:44

camielvs commented Dec 10, 2025

View reviewed changes

src/components/shared/TaskDetails/Actions.tsx Outdated Show resolved Hide resolved

camielvs force-pushed the 12-02-cleanup_taskdetails branch from cd9af2c to da5cc4e Compare December 10, 2025 21:28

camielvs force-pushed the 12-04-cleanup_executiondetails branch from aa47905 to 8a01b0d Compare December 10, 2025 21:29

This was referenced Dec 10, 2025

Rework Run Action Buttons into Action Framework #1524

Draft

Rework CodeViewer Implementation #1527

Draft

camielvs force-pushed the 12-02-cleanup_taskdetails branch from da5cc4e to 357442f Compare December 11, 2025 00:23

camielvs force-pushed the 12-04-cleanup_executiondetails branch 2 times, most recently from 10df8cb to 113b8c5 Compare December 11, 2025 00:34

camielvs force-pushed the 12-02-cleanup_taskdetails branch 2 times, most recently from 2ec7056 to 0d5df0e Compare December 11, 2025 00:36

camielvs force-pushed the 12-04-cleanup_executiondetails branch from 113b8c5 to 16212fb Compare December 11, 2025 00:36

camielvs force-pushed the 12-02-cleanup_taskdetails branch from 0d5df0e to de10ea2 Compare December 11, 2025 00:51

camielvs force-pushed the 12-04-cleanup_executiondetails branch from 16212fb to ddf0ce3 Compare December 11, 2025 00:51

camielvs force-pushed the 12-02-cleanup_taskdetails branch 2 times, most recently from f02a8a8 to 894609c Compare December 11, 2025 01:02

camielvs commented Dec 11, 2025

View reviewed changes

camielvs force-pushed the 12-04-cleanup_executiondetails branch from ddf0ce3 to ef66839 Compare December 11, 2025 20:26

camielvs force-pushed the 12-02-cleanup_taskdetails branch from 894609c to d1c04fd Compare December 11, 2025 20:26

camielvs mentioned this pull request Dec 11, 2025

Rework Task Action Buttons into Action Framework #1534

Draft

3 tasks

camielvs force-pushed the 12-04-cleanup_executiondetails branch from ef66839 to ad96688 Compare December 11, 2025 23:09

camielvs force-pushed the 12-02-cleanup_taskdetails branch 2 times, most recently from 654f141 to 215a2fd Compare December 12, 2025 00:44

camielvs force-pushed the 12-04-cleanup_executiondetails branch from ad96688 to c8b7768 Compare December 12, 2025 00:44

camielvs mentioned this pull request Dec 12, 2025

Rework Pipeline Action Buttons into Action Framework #1544

Draft

3 tasks

camielvs force-pushed the 12-02-cleanup_taskdetails branch from 215a2fd to de8701b Compare December 12, 2025 22:08

camielvs force-pushed the 12-04-cleanup_executiondetails branch from c8b7768 to 00ae3d5 Compare December 12, 2025 22:08

Cleanup TaskDetails

c316dac

camielvs force-pushed the 12-02-cleanup_taskdetails branch from de8701b to c316dac Compare December 13, 2025 00:23

camielvs force-pushed the 12-04-cleanup_executiondetails branch from 00ae3d5 to bde6c26 Compare December 13, 2025 00:23

camielvs mentioned this pull request Dec 13, 2025

Break TaskActions into two sections #1550

Draft

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cleanup TaskDetails #1464

Cleanup TaskDetails #1464

Uh oh!

camielvs commented Dec 2, 2025 •

edited

Loading

Uh oh!

camielvs commented Dec 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxy-shpfy Dec 4, 2025

Uh oh!

maxy-shpfy Dec 4, 2025

Uh oh!

Uh oh!

maxy-shpfy Dec 4, 2025

Uh oh!

Uh oh!

maxy-shpfy Dec 4, 2025

Uh oh!

maxy-shpfy left a comment

Uh oh!

Uh oh!

camielvs Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Cleanup TaskDetails #1464

Are you sure you want to change the base?

Cleanup TaskDetails #1464

Uh oh!

Conversation

camielvs commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue and Pull requests

Type of Change

Checklist

Screenshots (if applicable)

Test Instructions

Additional Comments

Uh oh!

camielvs commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxy-shpfy Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

maxy-shpfy Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maxy-shpfy Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maxy-shpfy Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

maxy-shpfy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

camielvs Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camielvs commented Dec 2, 2025 •

edited

Loading

camielvs commented Dec 2, 2025 •

edited

Loading