forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 4
Rework CodeViewer Implementation #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
camielvs
wants to merge
1
commit into
12-09-cleanup_rundetails
Choose a base branch
from
12-10-rework_codeviewer_implementation
base: 12-09-cleanup_rundetails
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rework CodeViewer Implementation #1527
camielvs
wants to merge
1
commit into
12-09-cleanup_rundetails
from
12-10-rework_codeviewer_implementation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2025
Merged
Draft
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
541ae4c to
dd7fc57
Compare
8737a95 to
73c5435
Compare
13b3154 to
a243c75
Compare
73c5435 to
73e7131
Compare
a243c75 to
1139464
Compare
73e7131 to
2a0ccca
Compare
1139464 to
1dd8730
Compare
2a0ccca to
f8e3134
Compare
1dd8730 to
0e92bae
Compare
f8e3134 to
e677909
Compare
19707ab to
726344b
Compare
65234bf to
7617cac
Compare
726344b to
5b89d37
Compare
7617cac to
c74095b
Compare
5f2112e to
0d02f62
Compare
c74095b to
5c47b5a
Compare
3 tasks
0d02f62 to
1714799
Compare
5c47b5a to
1e9e0cb
Compare
1714799 to
6297e96
Compare
1e9e0cb to
0550c7e
Compare
3 tasks
6297e96 to
4c3fa9a
Compare
0550c7e to
2fc0aeb
Compare
4c3fa9a to
c289d49
Compare
2fc0aeb to
2c5eafa
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Rework the codeviewer so the fullscreen button is not embedded into the CodeVier component itself, and change the CodeViewer component to be controller rather than uncontrolled. it now focusses purely on displaying code inline or fullscreen, and does not concern itself with its triggering button.
Toggling functionality is moved to the TaskImplementation component, allowing the CodeViewer to be used without specifically requiring a button (i.e. it can be controlled programmatically). As such, this requires a slightly more manual implementation across current CodeViewer usage.
Note: I didn't want to get bogged down with trying to move all the
divs in CodeViewer onto BlockStack. I feel that given it's a bespoke component it's probably okay for now to leave as-is.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
No change to app functionality. Code architecture update only. Confirm that the CodeViewer still behaves as expected.
Test Instructions
Additional Comments