Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Dec 10, 2025

Description

Rework the codeviewer so the fullscreen button is not embedded into the CodeVier component itself, and change the CodeViewer component to be controller rather than uncontrolled. it now focusses purely on displaying code inline or fullscreen, and does not concern itself with its triggering button.

Toggling functionality is moved to the TaskImplementation component, allowing the CodeViewer to be used without specifically requiring a button (i.e. it can be controlled programmatically). As such, this requires a slightly more manual implementation across current CodeViewer usage.

Note: I didn't want to get bogged down with trying to move all the divs in CodeViewer onto BlockStack. I feel that given it's a bespoke component it's probably okay for now to leave as-is.

Related Issue and Pull requests

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

No change to app functionality. Code architecture update only. Confirm that the CodeViewer still behaves as expected.

Test Instructions

Additional Comments

Copy link
Collaborator Author

camielvs commented Dec 10, 2025

@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 541ae4c to dd7fc57 Compare December 10, 2025 22:50
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 8737a95 to 73c5435 Compare December 10, 2025 22:50
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch 3 times, most recently from 13b3154 to a243c75 Compare December 10, 2025 23:31
@camielvs camielvs changed the base branch from 12-10-rework_action_buttons_into_new_action_framework to graphite-base/1527 December 10, 2025 23:40
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from a243c75 to 1139464 Compare December 10, 2025 23:41
@camielvs camielvs changed the base branch from graphite-base/1527 to 12-09-cleanup_rundetails December 10, 2025 23:41
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 73e7131 to 2a0ccca Compare December 11, 2025 00:23
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 1139464 to 1dd8730 Compare December 11, 2025 00:23
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 2a0ccca to f8e3134 Compare December 11, 2025 00:34
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 1dd8730 to 0e92bae Compare December 11, 2025 00:34
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from f8e3134 to e677909 Compare December 11, 2025 00:36
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch 2 times, most recently from 19707ab to 726344b Compare December 11, 2025 00:51
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch 2 times, most recently from 65234bf to 7617cac Compare December 11, 2025 00:56
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 726344b to 5b89d37 Compare December 11, 2025 00:56
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 7617cac to c74095b Compare December 11, 2025 01:02
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch 2 times, most recently from 5f2112e to 0d02f62 Compare December 11, 2025 20:26
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from c74095b to 5c47b5a Compare December 11, 2025 20:26
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 0d02f62 to 1714799 Compare December 11, 2025 23:09
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 5c47b5a to 1e9e0cb Compare December 11, 2025 23:09
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 1714799 to 6297e96 Compare December 12, 2025 00:44
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 1e9e0cb to 0550c7e Compare December 12, 2025 00:44
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 6297e96 to 4c3fa9a Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 0550c7e to 2fc0aeb Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 4c3fa9a to c289d49 Compare December 13, 2025 00:23
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 2fc0aeb to 2c5eafa Compare December 13, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants