Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Dec 11, 2025

Description

Moves all of the action buttons on the task card into the new ActionBlock Action type for consistency of UI and implementation.

This PR also tidies up where actions are defined. Previously they were scattered over various files. Now:

  • TaskNode actions are defined in TaskNodeCard
  • ComponentDetails actions are defined in ComponentDetailsDialog (currently none)
  • shared actions are in TaskActions

More specifically:

TaskNodeCard

  • Duplicate Task
  • Update from Source
  • Enter Subgraph
  • Edit Definition -> moved to TaskActions

TaskOverview

  • View YAML -> moved to TaskNodeCard

ComponentDetailsDialog

  • Edit Definition (again!) -> removed

TaskActions

  • Download YAML
  • Download Python
  • Copy YAML
  • Delete (if onDelete is provided)

Due to this change the component editor action was moved to TaskAction (it is shared), allowing us to consolidate down to one implementation of the ComponentEditor, rather than two. Additionally, the View YAML action was moved from TaskOverview to colocate with other actions in TaskNodeCard. TaskOverview is now a pass-through component as far as actions are concerned.

image.png

Related Issue and Pull requests

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

No change to app functionality.

Confirm that all buttons in TaskActions & ComponentDetailsDialog look consistent and continue to function as expected.

Additional Comments

Copy link
Collaborator Author

camielvs commented Dec 11, 2025

@camielvs camielvs mentioned this pull request Dec 11, 2025
3 tasks
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 05a1298 to fe07e23 Compare December 11, 2025 23:09
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 442d3d8 to b5bc3a7 Compare December 11, 2025 23:09
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch 2 times, most recently from ea15e3d to 4b7d2a6 Compare December 12, 2025 00:44
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from b5bc3a7 to 92df4ce Compare December 12, 2025 00:44
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 4b7d2a6 to f2cfc9c Compare December 12, 2025 00:52
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 92df4ce to 3f06300 Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from f2cfc9c to 1173005 Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 3f06300 to b75cc60 Compare December 13, 2025 00:23
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 1173005 to b9aa264 Compare December 13, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants