Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Dec 10, 2025

Description

Action buttons in RunDetails follow the Action type style (rather than passing a straight ReactNode e.g. styled button). This ensures consistency of the interface, and makes it easy to implement new actions later.

This change requires some rework of the various RunDetails Buttons and the TaskImplementation. To formulate the actions list a new useRunActions hook was added. Tests for these components have been, similarly, moved into a new consolidated test file for the hook.

Related Issue and Pull requests

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

No change to app functionality.

Confirm that all buttons in RunActions look consistent and continue to function as expected.

Additional Comments

Copy link
Collaborator Author

camielvs commented Dec 10, 2025

@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 8737a95 to 73c5435 Compare December 10, 2025 22:50
@camielvs camielvs changed the base branch from 12-09-cleanup_rundetails to graphite-base/1524 December 10, 2025 23:41
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 73c5435 to f5b8ed7 Compare December 10, 2025 23:41
@camielvs camielvs changed the base branch from graphite-base/1524 to 12-10-rework_codeviewer_implementation December 10, 2025 23:41
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from f5b8ed7 to 0fdda14 Compare December 11, 2025 00:20
@camielvs camielvs changed the title Rework Action Buttons into new Action Framework Rework RunDetails Action Buttons into new Action Framework Dec 11, 2025
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 0fdda14 to 6ac7507 Compare December 11, 2025 00:23
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 1dd8730 to 0e92bae Compare December 11, 2025 00:34
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch 2 times, most recently from f1367b4 to 1c75c23 Compare December 11, 2025 00:36
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 0e92bae to 19707ab Compare December 11, 2025 00:36
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 1c75c23 to 22fcc25 Compare December 11, 2025 00:51
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 19707ab to 726344b Compare December 11, 2025 00:51
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 22fcc25 to 19bc578 Compare December 11, 2025 00:56
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 726344b to 5b89d37 Compare December 11, 2025 00:56
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 19bc578 to f8982e3 Compare December 11, 2025 01:02
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 5b89d37 to 5f2112e Compare December 11, 2025 01:02
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from f8982e3 to 442d3d8 Compare December 11, 2025 20:26
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 5f2112e to 0d02f62 Compare December 11, 2025 20:26
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 442d3d8 to b5bc3a7 Compare December 11, 2025 23:09
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 0d02f62 to 1714799 Compare December 11, 2025 23:09
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 1714799 to 6297e96 Compare December 12, 2025 00:44
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from b5bc3a7 to 92df4ce Compare December 12, 2025 00:44
@camielvs camielvs changed the title Rework RunDetails Action Buttons into new Action Framework Rework RunDetails Action Buttons into Action Framework Dec 12, 2025
@camielvs camielvs changed the title Rework RunDetails Action Buttons into Action Framework Rework Run Action Buttons into Action Framework Dec 12, 2025
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 6297e96 to 4c3fa9a Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 92df4ce to 3f06300 Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 3f06300 to b75cc60 Compare December 13, 2025 00:23
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 4c3fa9a to c289d49 Compare December 13, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants