forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
Rework Run Action Buttons into Action Framework #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
camielvs
wants to merge
1
commit into
12-10-rework_codeviewer_implementation
Choose a base branch
from
12-10-rework_action_buttons_into_new_action_framework
base: 12-10-rework_codeviewer_implementation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rework Run Action Buttons into Action Framework #1524
camielvs
wants to merge
1
commit into
12-10-rework_codeviewer_implementation
from
12-10-rework_action_buttons_into_new_action_framework
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 10, 2025
Merged
Draft
8737a95 to
73c5435
Compare
73c5435 to
f5b8ed7
Compare
f5b8ed7 to
0fdda14
Compare
0fdda14 to
6ac7507
Compare
1dd8730 to
0e92bae
Compare
f1367b4 to
1c75c23
Compare
0e92bae to
19707ab
Compare
1c75c23 to
22fcc25
Compare
19707ab to
726344b
Compare
22fcc25 to
19bc578
Compare
726344b to
5b89d37
Compare
19bc578 to
f8982e3
Compare
5b89d37 to
5f2112e
Compare
f8982e3 to
442d3d8
Compare
5f2112e to
0d02f62
Compare
3 tasks
442d3d8 to
b5bc3a7
Compare
0d02f62 to
1714799
Compare
1714799 to
6297e96
Compare
b5bc3a7 to
92df4ce
Compare
3 tasks
6297e96 to
4c3fa9a
Compare
92df4ce to
3f06300
Compare
3f06300 to
b75cc60
Compare
4c3fa9a to
c289d49
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Action buttons in RunDetails follow the Action type style (rather than passing a straight ReactNode e.g. styled button). This ensures consistency of the interface, and makes it easy to implement new actions later.
This change requires some rework of the various RunDetails Buttons and the TaskImplementation. To formulate the actions list a new
useRunActionshook was added. Tests for these components have been, similarly, moved into a new consolidated test file for the hook.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
No change to app functionality.
Confirm that all buttons in RunActions look consistent and continue to function as expected.
Additional Comments