Skip to content

Fix Node Replacement Issues on IO Rename #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
camielvs wants to merge 1 commit into
base: 09-29-implement_node_manager
Choose a base branch
from
Draft

Fix Node Replacement Issues on IO Rename #1083

camielvs wants to merge 1 commit into from

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Oct 8, 2025 •
edited
Loading

Description

Follow-up to #846

This PR fixes the issue we were having with renamed IO nodes creating a replacement node in ReactFlow and thus causing issues with persistent state (e.g. selection & highlighting). This PR replaces the workaround useNodeSelectionTransfer logic with a simple migration via the new Node manager.

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/296
Closes https://github.com/Shopify/oasis-frontend/issues/263
Closes https://github.com/Shopify/oasis-frontend/issues/331

Type of Change

  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Rename an input node - it should update smoothly and the node or context panel should not flicker or close & reopen
  2. same as above for output node renaming

Additional Comments

This was referenced Oct 8, 2025
Closed
Closed
@camielvs Graphite App
Copy link
Collaborator Author

camielvs commented Oct 8, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from b6be3d3 to 81c1c02 Compare October 8, 2025 20:02
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from cb246d1 to 10b7c60 Compare October 8, 2025 20:02
@camielvs camielvs changed the base branch from 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids to graphite-base/1083 October 8, 2025 20:08
@camielvs camielvs changed the base branch from graphite-base/1083 to 09-29-implement_node_manager October 8, 2025 20:09
This was referenced Oct 8, 2025
Draft
Closed
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 81c1c02 to f7b4701 Compare October 8, 2025 20:17
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 10b7c60 to 55e80d8 Compare October 8, 2025 20:17
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from f7b4701 to 6f7964f Compare October 9, 2025 00:37
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 55e80d8 to 0dea688 Compare October 9, 2025 00:37
This was referenced Oct 9, 2025
Closed
Closed
Draft
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 6f7964f to ed6dac3 Compare October 9, 2025 01:27
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from d39d198 to f2ff89f Compare October 9, 2025 01:44
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch 2 times, most recently from 8b1c325 to cdf173e Compare October 9, 2025 16:52
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from f2ff89f to 45e9d85 Compare October 9, 2025 16:52
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from cdf173e to f6ee2d9 Compare October 9, 2025 17:04
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 45e9d85 to 7e42fa6 Compare October 9, 2025 17:04
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from f6ee2d9 to b62b77d Compare October 9, 2025 17:15
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 7e42fa6 to 5b6b0d0 Compare October 9, 2025 17:15
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from b62b77d to d1ad079 Compare October 9, 2025 18:46
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from 2fa3659 to f7f0199 Compare October 9, 2025 19:19
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from d1ad079 to ba7a488 Compare October 9, 2025 19:19
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 2d86930 to b6c0b7d Compare October 17, 2025 21:41
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 3afa0a3 to 6e7153a Compare October 17, 2025 21:41
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from b6c0b7d to f4b579c Compare October 17, 2025 21:42
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 0c17c58 to 80fe92b Compare October 22, 2025 20:18
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from f4b579c to 4190130 Compare October 22, 2025 20:18
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 80fe92b to 4ebe9af Compare October 22, 2025 22:19
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 4190130 to 292963c Compare October 22, 2025 22:19
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 4ebe9af to a771300 Compare October 23, 2025 16:35
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 292963c to 76acaa5 Compare October 23, 2025 16:35
@camielvs camielvs mentioned this pull request Oct 23, 2025
Draft
3 tasks
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from a771300 to b0d1e49 Compare October 23, 2025 20:05
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 76acaa5 to 349bbc8 Compare October 23, 2025 20:05
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from b0d1e49 to 2cb7d00 Compare October 23, 2025 20:11
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 349bbc8 to 28a303a Compare October 23, 2025 20:11
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 2cb7d00 to 8e578be Compare October 23, 2025 23:23
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from 3abfd3a to cddf9de Compare October 24, 2025 00:15
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch 2 times, most recently from 9818be3 to 705d37e Compare October 28, 2025 21:04
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from cddf9de to 4ba5633 Compare October 28, 2025 21:04
This was referenced Oct 28, 2025
Draft
Closed
@maxy-shpfy maxy-shpfy marked this pull request as draft October 30, 2025 16:55
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 705d37e to 856c31c Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 4ba5633 to 0bd4ecc Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 856c31c to d672fba Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 0bd4ecc to 4601f48 Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 4601f48 to 7a8cb63 Compare October 31, 2025 00:23
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from d672fba to a8814d2 Compare October 31, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxy-shpfy maxy-shpfy Awaiting requested review from maxy-shpfy

@Mbeaulne Mbeaulne Awaiting requested review from Mbeaulne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camielvs @Mbeaulne @maxy-shpfy