forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
Implement Node Manager #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
camielvs
wants to merge
1
commit into
10-07-usenodemanager_hook
Choose a base branch
from
09-29-implement_node_manager
base: 10-07-usenodemanager_hook
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement Node Manager #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2025
Draft
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
62e4c7d to
8c27ed8
Compare
This was referenced Sep 30, 2025
8132fb5 to
af581a3
Compare
8c27ed8 to
46676ff
Compare
This was referenced Oct 2, 2025
af581a3 to
5b8b110
Compare
46676ff to
9cab80e
Compare
9cab80e to
50cbbc2
Compare
5b8b110 to
c55eb6c
Compare
c55eb6c to
aef47ff
Compare
2f84d5f to
10473ce
Compare
10473ce to
8396c6f
Compare
8396c6f to
83ecf4a
Compare
1910574 to
755167d
Compare
3afa0a3 to
6e7153a
Compare
089c958 to
b79c576
Compare
0c17c58 to
80fe92b
Compare
4dce064 to
846582d
Compare
4ebe9af to
a771300
Compare
3 tasks
1c05e06 to
588f464
Compare
b0d1e49 to
2cb7d00
Compare
588f464 to
36aac5b
Compare
2cb7d00 to
8e578be
Compare
36aac5b to
70a3943
Compare
8e578be to
9818be3
Compare
70a3943 to
6a50c55
Compare
9818be3 to
705d37e
Compare
07c7df4 to
beded30
Compare
856c31c to
d672fba
Compare
d672fba to
a8814d2
Compare
59a4d8f to
55384a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Replace all task/input/output -> node id conversions with the new NodeManager. In other words, the
nodeIdUtilsfile has been replaced with the new NodeManager.i.e. replace all instances of
inputNameToNodeId,outputNameToNodeId, andtaskIdToNodeId(and the reverse operations) with the NodeManager'sgetNodeIdandgetRefIdmethods (orgetInputNodeIdandgetOutputNodeIdvia theuseNodeManagerhook). This also includes replacement of all methods dealing with Handle ids as well, and these have been brought into the node manager viagetHandleNodeIdandgetHandleInfo.inputNameToNodeId-->getInputNodeIdoutputNameToNodeId-->getOutputNodeIdtaskIdToNodeId-->getTaskNodeIdAll nodes & handles will now have a uniquely assigned node id for use in ReactFlow and via the NodeManager this is mapped back to their respective id in the component spec. For handles they are mapped to the parent object they are one.
Also includes a few minor refactors such as
removeEdge, to make things more human-readable.Includes some AI-generated updates to tests.
Closes Shopify/oasis-frontend#261
Type of Change
Checklist
Test Instructions
etc