Separate IONodeData type from TaskNodeData type

[camielvs]

Description

Separates the NodeData types for IO Nodes vs Task Nodes. This allows stricter and more easily-followed type definitions for data within nodes. e.g. IO Nodes will no longer receive pointless amounts of task-node data such as isGhost or callbacks.

taskNode type file and hintNode type file have also been co-located together into a singular nodes type file.

No change to app functionality.

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/327

Type of Change

• Cleanup/Refactor

Checklist

• I have tested this does not break current pipelines / runs functionality
• I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Task Nodes

1. Create a task node

• Drag a component from the library onto the canvas
• Verify the node renders correctly with all task information

2. Edit task node arguments

• Click on a task node
• Modify arguments in the context panel
• Verify changes are saved correctly

3. Delete a task node

• Select a task node and delete it
• Verify the node is removed from the canvas and graph

4. Duplicate a task node

• Select a task node and duplicate it
• Verify the duplicate appears with a unique ID

Input/Output Nodes

1. Create input and output nodes

• Add an input node to the canvas
• Add an output node to the canvas
• Verify both render with correct labels and type information

2. Edit IO node properties

• Click on an input/output node
• Modify its properties in the context panel (name, type, default value)
• Verify changes are reflected in the node

3. Connect IO nodes

• Connect an input node to a task node input
• Connect a task node output to an output node
• Verify connections work correctly

General Operations

1. Copy and paste nodes

• Select multiple nodes (mix of task, input, output)
• Copy and paste them
• Verify all node types paste correctly with proper data

(note some existing copy + paste functionality does not work with IO nodes)

2. Undo/redo operations

• Perform various operations on different node types
• Test undo/redo functionality
• Verify all node types maintain correct state

3. Save and reload

• Make changes to a component with various node types
• Save the component
• Reload and verify all nodes retain their data correctly

Additional Comments

[camielvs]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• useNodeManager Hook #1082 : 2 dependent PRs (#930 , #1004 )
• Provide Node Manager #1081
• Add Node Manager #929
• Groundwork for Id Conversions #1090
• Separate IONodeData type from TaskNodeData type #928 👈 (View in Graphite)
• Refactor Dynamic Node Callbacks #927
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[camielvs]

Good catch - Fixed!

[Mbeaulne]

inputs and outputs are now registering as output nodes

[Mbeaulne]

inputs and outputs are now registering as output nodes

[camielvs]

Fixed - it appears we don't have enough info for the new isInputSpec method to infer whether a node is an Input or Output. I've now added a secondary check via node.type.

[maxy-shpfy]

Small regression (compared to staging - at the end of the video):

1. create Input node. It is marked as "INVALID" at 3 places (pipeline validation, canvas node, context panel).
2. input value. Validation now passed.
3. remove value. Validation fails again. But now the node is Marked as INVALID just in 2 places (canvas node skipped). --- BUG

Screen Recording 2025-10-23 at 4.24.47 PM.mov (uploaded via Graphite)

[camielvs]

Fixed!