Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Oct 7, 2025

Description

Add a hook useNodeManager to simplify common node manager tasks. This is essentially a wrapper around NodeManager via ComponentSpecProvider.

No change to app functionality. Implementation will come in upstack PRs.

Related Issue and Pull requests

Progresses https://github.com/Shopify/oasis-frontend/issues/261

Type of Change

  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Wrapper around nodeManager.ts without any implementation. There isn't really any testing to do here as the operations are very simple.

Additional Comments

Copy link
Collaborator Author

camielvs commented Oct 7, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs mentioned this pull request Oct 7, 2025
3 tasks
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from e6f53b7 to 649681c Compare October 8, 2025 16:16
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch 2 times, most recently from 263ddb7 to 17ccb35 Compare October 8, 2025 16:31
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from 649681c to 0ade3f6 Compare October 8, 2025 16:31
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 17ccb35 to ee03616 Compare October 8, 2025 16:52
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch 2 times, most recently from 34446e1 to aad4aee Compare October 8, 2025 17:20
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch 2 times, most recently from 6c77cd9 to 1073324 Compare October 8, 2025 17:58
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from aad4aee to 8547350 Compare October 8, 2025 17:58
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch 2 times, most recently from ccad217 to 379c1b4 Compare October 8, 2025 20:17
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 379c1b4 to e2facc6 Compare October 9, 2025 01:27
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from 49aea78 to 3059e4f Compare October 9, 2025 01:27
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 089c958 to b79c576 Compare October 17, 2025 21:42
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch 2 times, most recently from 896ecc2 to e1cbc87 Compare October 22, 2025 20:18
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch 2 times, most recently from 4dce064 to 846582d Compare October 22, 2025 22:19
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from 3fd626c to ef00f3d Compare October 23, 2025 16:35
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 846582d to 1c05e06 Compare October 23, 2025 16:35
@camielvs camielvs changed the base branch from 10-07-provide_node_manager to graphite-base/1082 October 23, 2025 19:34
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 1c05e06 to 588f464 Compare October 23, 2025 20:05
@camielvs camielvs changed the base branch from graphite-base/1082 to 10-07-provide_node_manager October 23, 2025 20:05
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from bd9b6ec to c298c28 Compare October 23, 2025 20:11
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 588f464 to 36aac5b Compare October 23, 2025 20:11
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from c298c28 to 5b77dd5 Compare October 23, 2025 23:23
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 36aac5b to 70a3943 Compare October 23, 2025 23:23
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from 5b77dd5 to 147f93b Compare October 24, 2025 00:15
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 70a3943 to 6a50c55 Compare October 24, 2025 00:15
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from 147f93b to 018c432 Compare October 28, 2025 21:04
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 6a50c55 to 07c7df4 Compare October 28, 2025 21:04
@camielvs camielvs mentioned this pull request Oct 28, 2025
4 tasks
@maxy-shpfy maxy-shpfy marked this pull request as draft October 30, 2025 16:55
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from 018c432 to f5fd58d Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 07c7df4 to beded30 Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from f5fd58d to cab0b82 Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from beded30 to 59a4d8f Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-07-usenodemanager_hook branch from 59a4d8f to 55384a0 Compare October 31, 2025 00:23
@camielvs camielvs force-pushed the 10-07-provide_node_manager branch from cab0b82 to 5242c5e Compare October 31, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants