forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
useNodeManager Hook #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
camielvs
wants to merge
2
commits into
10-07-provide_node_manager
Choose a base branch
from
10-07-usenodemanager_hook
base: 10-07-provide_node_manager
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
useNodeManager Hook #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2025
Draft
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e6f53b7 to
649681c
Compare
263ddb7 to
17ccb35
Compare
649681c to
0ade3f6
Compare
17ccb35 to
ee03616
Compare
34446e1 to
aad4aee
Compare
6c77cd9 to
1073324
Compare
aad4aee to
8547350
Compare
3 tasks
ccad217 to
379c1b4
Compare
This was referenced Oct 9, 2025
379c1b4 to
e2facc6
Compare
49aea78 to
3059e4f
Compare
089c958 to
b79c576
Compare
896ecc2 to
e1cbc87
Compare
4dce064 to
846582d
Compare
3fd626c to
ef00f3d
Compare
846582d to
1c05e06
Compare
3 tasks
ef00f3d to
bd9b6ec
Compare
1c05e06 to
588f464
Compare
bd9b6ec to
c298c28
Compare
588f464 to
36aac5b
Compare
c298c28 to
5b77dd5
Compare
36aac5b to
70a3943
Compare
5b77dd5 to
147f93b
Compare
70a3943 to
6a50c55
Compare
147f93b to
018c432
Compare
6a50c55 to
07c7df4
Compare
018c432 to
f5fd58d
Compare
07c7df4 to
beded30
Compare
f5fd58d to
cab0b82
Compare
beded30 to
59a4d8f
Compare
59a4d8f to
55384a0
Compare
cab0b82 to
5242c5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Add a hook
useNodeManagerto simplify common node manager tasks. This is essentially a wrapper around NodeManager via ComponentSpecProvider.No change to app functionality. Implementation will come in upstack PRs.
Related Issue and Pull requests
Progresses https://github.com/Shopify/oasis-frontend/issues/261
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Wrapper around
nodeManager.tswithout any implementation. There isn't really any testing to do here as the operations are very simple.Additional Comments