Provide Node Manager #1081
Draft
Provide Node Manager #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2025
Draft
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 7, 2025
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
649681c to
0ade3f6
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
43a282b to
3e1ef82
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
34446e1 to
aad4aee
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
2 times, most recently
from
47571c0 to
bf97171
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
aad4aee to
8547350
Compare
3 tasks
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
bf97171 to
a82859b
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
8547350 to
49aea78
Compare
This was referenced Oct 9, 2025
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
a82859b to
0fb361e
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
3059e4f to
baed2e5
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
0fb361e to
d97b96e
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
4f02c76 to
a957df5
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
2 times, most recently
from
0e9a8ad to
13d6255
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
896ecc2 to
e1cbc87
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
2 times, most recently
from
e98225e to
7ab0232
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
3fd626c to
ef00f3d
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
7ab0232 to
68217dd
Compare
3 tasks
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
68217dd to
f148c44
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
bd9b6ec to
c298c28
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
f148c44 to
e3374bf
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
c298c28 to
5b77dd5
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
2 times, most recently
from
36ea9e6 to
a3b0e3f
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
5b77dd5 to
147f93b
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
a3b0e3f to
8114ef9
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
147f93b to
018c432
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
f5fd58d to
cab0b82
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
5472e7b to
ad2e6c4
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
cab0b82 to
5242c5e
Compare
camielvs
force-pushed
the
09-19-add_node_manager
branch
from
ad2e6c4 to
0fa81ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate the new NodeManager with
ComponentSpecProviderso that the nodes stay in sync with the component spec.No change to app functionality. Consumption of the node manager is implemented later.
Related Issue and Pull requests
Progresses https://github.com/Shopify/oasis-frontend/issues/261
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Just adds a new export to the componentspec provider, but does not consume it. So if the app is, in general, functioning as expected, all should be well.
Additional Comments